fix: Asymmetric Payout Arithmetic and Consistency Refactor#346
Merged
gboigwe merged 1 commit intoThinkLikeAFounder:mainfrom Mar 28, 2026
Merged
Conversation
|
@Dopezapha Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #307
Description
This PR resolves a critical inconsistency in the
payout-automationcontract wheretotal_paidcalculations were unchecked whilepending_amountused saturating arithmetic (#307). This asymmetry previously masked accounting bugs and could lead to silent data corruption or illogical contract states.Key Changes
Consistently Checked Arithmetic: All financial state transitions for
PublisherEarningsnow usechecked_addandchecked_subwith explicit error handling.Improved Diagnostics: Updated the failure messages in
execute_payoutto correctly identify underflows inpending_earnings, facilitating better troubleshooting of upstream registry errors.Entry-Point Hardening: Added non-zero validation and minimum payout enforcement (reading from contract instance storage) to
schedule_payoutto prevent logic inversions.Ledger Counter Safety: Upgraded the
payout_idsequence to a checked counter.